[webkit-reviews] review granted: [Bug 182729] run-jsc-stress-tests - skip a test if any of the run commands evals to skip : [Attachment 333688] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 15 08:17:14 PST 2018


Saam Barati <sbarati at apple.com> has granted Tomas Popela <tpopela at redhat.com>'s
request for review:
Bug 182729: run-jsc-stress-tests - skip a test if any of the run commands evals
to skip
https://bugs.webkit.org/show_bug.cgi?id=182729

Attachment 333688: Patch

https://bugs.webkit.org/attachment.cgi?id=333688&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 333688
  --> https://bugs.webkit.org/attachment.cgi?id=333688
Patch

r=me

The only thing slightly unintuitive here is you could have code like:
//@ runXYZ
//@ skip

And we’ll print out that we’re skipping. But it’s probably ok to not care about
this


More information about the webkit-reviews mailing list