[webkit-reviews] review granted: [Bug 182824] Clean up HarfBuzzFaceCairo : [Attachment 333884] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 182824: Clean up HarfBuzzFaceCairo
https://bugs.webkit.org/show_bug.cgi?id=182824

Attachment 333884: Patch

https://bugs.webkit.org/attachment.cgi?id=333884&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 333884
  --> https://bugs.webkit.org/attachment.cgi?id=333884
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333884&action=review

> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:91
> +    cairo_scaled_font_t* scaledFont = hbFontData.cairoScaledFont.get();

auto*

> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:94
> +    WTF::HashMap<uint32_t, uint16_t>::AddResult result =
hbFontData.glyphCacheForFaceCacheEntry->add(unicode, 0);

0 -> nullptr

> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:117
> +    cairo_scaled_font_t* scaledFont = hbFontData.cairoScaledFont.get();

auto*

> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:135
> +    cairo_scaled_font_t* scaledFont = hbFontData.cairoScaledFont.get();

auto*