[webkit-reviews] review requested: [Bug 174516] Butterfly storage need not be initialized for indexing type Undecided. : [Attachment 333826] New patch, includes some refactoring

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 14 16:37:04 PST 2018


Robin Morisset <rmorisset at apple.com> has asked	for review:
Bug 174516: Butterfly storage need not be initialized for indexing type
Undecided.
https://bugs.webkit.org/show_bug.cgi?id=174516

Attachment 333826: New patch, includes some refactoring

https://bugs.webkit.org/attachment.cgi?id=333826&action=review




--- Comment #16 from Robin Morisset <rmorisset at apple.com> ---
Comment on attachment 333826
  --> https://bugs.webkit.org/attachment.cgi?id=333826
New patch, includes some refactoring

I cannot reproduce this test failing. I suspect it might be flaky, especially
considering this test does not seem to be calling concat. I would like a review
while I check in more depth what could have made the bot fail.


More information about the webkit-reviews mailing list