[webkit-reviews] review denied: [Bug 182479] [Win] Fix MSVC's treating __attribute__((warn_unused_result)) : [Attachment 333152] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Yousuke Kimoto
<Yousuke.Kimoto at sony.com>'s request for review:
Bug 182479: [Win] Fix MSVC's treating __attribute__((warn_unused_result))
https://bugs.webkit.org/show_bug.cgi?id=182479

Attachment 333152: Patch

https://bugs.webkit.org/attachment.cgi?id=333152&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 333152
  --> https://bugs.webkit.org/attachment.cgi?id=333152
Patch

This is the wrong fix. The correct fix would be to use WARN_UNUSED_RETURN from
Compiler.h instead of using warn_unused_result directly.