[webkit-reviews] review denied: [Bug 182479] [Win] Fix MSVC's treating __attribute__((warn_unused_result)) : [Attachment 333152] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 14 16:36:10 PST 2018

Darin Adler <darin at apple.com> has denied Yousuke Kimoto
<Yousuke.Kimoto at sony.com>'s request for review:
Bug 182479: [Win] Fix MSVC's treating __attribute__((warn_unused_result))

Attachment 333152: Patch


--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 333152
  --> https://bugs.webkit.org/attachment.cgi?id=333152

This is the wrong fix. The correct fix would be to use WARN_UNUSED_RETURN from
Compiler.h instead of using warn_unused_result directly.

More information about the webkit-reviews mailing list