[webkit-reviews] review granted: [Bug 182804] We should be able to jsDynamicCast from JSType when possible : [Attachment 333853] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 182804: We should be able to jsDynamicCast from JSType when possible
https://bugs.webkit.org/show_bug.cgi?id=182804

Attachment 333853: Patch

https://bugs.webkit.org/attachment.cgi?id=333853&action=review




--- Comment #8 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 333853
  --> https://bugs.webkit.org/attachment.cgi?id=333853
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333853&action=review

r=me assuming you put out the bot fire.

> Source/JavaScriptCore/ChangeLog:10
> +	   This patch beefs up jsDynamicCast in some of the cases where we
> +	   can use the JSType to quickly determine if a cell is a subclass of
> +	   the desired type.

you should say more about the mechanism, like the type range check.