[webkit-reviews] review granted: [Bug 182749] Web Automation: combine session commands to resize and move top-level browsing contexts : [Attachment 333824] Patch v2

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 182749: Web Automation: combine session commands to resize and move
top-level browsing contexts
https://bugs.webkit.org/show_bug.cgi?id=182749

Attachment 333824: Patch v2

https://bugs.webkit.org/attachment.cgi?id=333824&action=review




--- Comment #8 from Andy Estes <aestes at apple.com> ---
Comment on attachment 333824
  --> https://bugs.webkit.org/attachment.cgi?id=333824
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=333824&action=review

> Source/WebDriver/Session.cpp:747
> +	   RefPtr<JSON::Object> parameters = JSON::Object::create();

I'd use auto here, unless you really need this to be a RefPtr (maybe
sendCommandToBackend() needs a copyable lambda?).

> Source/WebDriver/Session.cpp:750
> +	       RefPtr<JSON::Object> windowOrigin = JSON::Object::create();

Ditto.