[webkit-reviews] review granted: [Bug 182579] Disallow cross-origin subresources from asking for credentials : [Attachment 333398] Patch and layout tests

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 182579: Disallow cross-origin subresources from asking for credentials
https://bugs.webkit.org/show_bug.cgi?id=182579

Attachment 333398: Patch and layout tests

https://bugs.webkit.org/attachment.cgi?id=333398&action=review




--- Comment #15 from Andy Estes <aestes at apple.com> ---
Comment on attachment 333398
  --> https://bugs.webkit.org/attachment.cgi?id=333398
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=333398&action=review

> Source/WebCore/loader/ResourceLoader.h:190
> +    bool canRequestAskUserForCredentials() const;

Can this just be called canAskUserForCredentials()? The first time I read this,
I interpreted request as a verb and got confused. I get that we're basing the
decision on the request URL, but maybe that fact doesn't need to be in the
function signature. r=me either way.