[webkit-reviews] review denied: [Bug 166474] ASSERT_NOT_REACHED() should always log error messages in Release builds : [Attachment 297741] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 14 10:36:43 PST 2018


Brady Eidson <beidson at apple.com> has denied David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 166474: ASSERT_NOT_REACHED() should always log error messages in Release
builds
https://bugs.webkit.org/show_bug.cgi?id=166474

Attachment 297741: Patch v1

https://bugs.webkit.org/attachment.cgi?id=297741&action=review




--- Comment #16 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 297741
  --> https://bugs.webkit.org/attachment.cgi?id=297741
Patch v1

Patches that have been up for review since 2016 are almost certainly too stale
to be relevant to trunk in their current form.

If this patch is still important please rebase it and post it for review again.


More information about the webkit-reviews mailing list