[webkit-reviews] review granted: [Bug 182741] [Web Animations] Make KeyframeEffect target nullable and read-write : [Attachment 333800] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 182741: [Web Animations] Make KeyframeEffect target nullable and read-write
https://bugs.webkit.org/show_bug.cgi?id=182741

Attachment 333800: Patch

https://bugs.webkit.org/attachment.cgi?id=333800&action=review




--- Comment #29 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 333800
  --> https://bugs.webkit.org/attachment.cgi?id=333800
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333800&action=review

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:78
> +    // FIXME: we don't support the CSS "offset" property

The remark after the FIXME should be complete sentences that begin with a
capital letter and ends with a period.

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:516
>      // 1. If object is null, return an empty sequence of keyframes.

This comment no longer matches what the code does OR I am unclear what "object"
refers to in this comment. Is the code correct?

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:517
> +    if (!keyframesInput.get())

No need for calling get(). It is sufficient to write this as:

if (!keyframesInput)

(Assuming this change is correct. See my remark above about the discrepancy
with the comment).

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:564
> +    if (!is<Document>(scriptExecutionContext))
> +	   return Exception { TypeError };

>From talking with you today in person, you clarified that this code would never
run in a worker. So, I suggest we turn this into an assertion and assert it at
the top of the function.