[webkit-reviews] review granted: [Bug 182564] REGRESSION (r223440): Copying & pasting a list from Microsoft Word to TinyMCE fails : [Attachment 333768] Fixed Evernote & Wordpress.com & MS Word's compat mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 14 07:42:16 PST 2018


Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 182564: REGRESSION (r223440): Copying & pasting a list from Microsoft Word
to TinyMCE fails
https://bugs.webkit.org/show_bug.cgi?id=182564

Attachment 333768: Fixed Evernote & Wordpress.com & MS Word's compat mode

https://bugs.webkit.org/attachment.cgi?id=333768&action=review




--- Comment #46 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 333768
  --> https://bugs.webkit.org/attachment.cgi?id=333768
Fixed Evernote & Wordpress.com & MS Word's compat mode

View in context: https://bugs.webkit.org/attachment.cgi?id=333768&action=review

> Source/WebCore/editing/markup.cpp:433
> +    if (m_shouldPreserveMSOList && element.hasTagName(pTag) &&
element.getAttribute(styleAttr).contains(";mso-list:"))

Nit - maybe add a new helper method for this called something like
`shouldPreserveMSOListStyleForElement`, and turn the above into a one-liner?


More information about the webkit-reviews mailing list