[webkit-reviews] review granted: [Bug 182668] Removing the controls attribute from a <video> element does not tear down the controls shadow DOM nor cancel event listeners. : [Attachment 333745] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 182668: Removing the controls attribute from a <video> element does not
tear down the controls shadow DOM nor cancel event listeners.
https://bugs.webkit.org/show_bug.cgi?id=182668

Attachment 333745: Patch

https://bugs.webkit.org/attachment.cgi?id=333745&action=review




--- Comment #11 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 333745
  --> https://bugs.webkit.org/attachment.cgi?id=333745
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333745&action=review

Do we have a test for verifying that the AirPlay plackard is shown when
initiating remote playback from a media element without a controls attribute?

> Source/WebCore/Modules/modern-media-controls/media/placard-support.js:51
> +	   if (this.mediaController.isFullscreen)

Does this need an iOS check? Presumably we still want the placards in Mac full
screen?