[webkit-reviews] review granted: [Bug 182698] Add C SPI for support of Website Data Store in Website Policies : [Attachment 333623] patch (referring to "C API" instead of "Legacy WebKit")

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Maureen Daum <mdaum at apple.com>'s
request for review:
Bug 182698: Add C SPI for support of Website Data Store in Website Policies
https://bugs.webkit.org/show_bug.cgi?id=182698

Attachment 333623: patch (referring to "C API" instead of "Legacy WebKit")

https://bugs.webkit.org/attachment.cgi?id=333623&action=review




--- Comment #8 from Andy Estes <aestes at apple.com> ---
Comment on attachment 333623
  --> https://bugs.webkit.org/attachment.cgi?id=333623
patch (referring to "C API" instead of "Legacy WebKit")

View in context: https://bugs.webkit.org/attachment.cgi?id=333623&action=review

> Source/WebKit/UIProcess/API/C/WKFramePolicyListener.cpp:54
> +	   RELEASE_ASSERT_WITH_MESSAGE(sessionID.isEphemeral() || sessionID ==
PAL::SessionID::defaultSessionID(), "WebsiteDataStore must be nil, default, or
non-persistent.");

The wording here isn't quite right, since "default" and "non-persistent" apply
to the data store's session, not the data store itself. Also, "nil" isn't the
right term in C.

> Source/WebKit/UIProcess/API/C/WKFramePolicyListener.cpp:55
> +	  
RELEASE_ASSERT_WITH_MESSAGE(toImpl(policyListenerRef)->isMainFrame(),
"WebsiteDataStore must be nil for subframe navigations.");

Same comment about "nil".

> Source/WebKit/UIProcess/WebFrameListenerProxy.h:50
> +    bool isMainFrame();

This should be const-qualified.