[webkit-reviews] review granted: [Bug 182717] [JSC] cache TaggedTemplate arrays by callsite rather than by contents : [Attachment 333671] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Caitlin Potter (:caitp)
<caitp at igalia.com>'s request for review:
Bug 182717: [JSC] cache TaggedTemplate arrays by callsite rather than by
contents
https://bugs.webkit.org/show_bug.cgi?id=182717

Attachment 333671: Patch

https://bugs.webkit.org/attachment.cgi?id=333671&action=review




--- Comment #5 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 333671
  --> https://bugs.webkit.org/attachment.cgi?id=333671
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333671&action=review

r=me with test262.yaml update. Since test262 includes tests for this, we should
update test262.yaml.

> Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp:75
> +    , m_hasTaggedTemplates(false)

Drop this since it is not used.

> Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h:457
> +    unsigned m_hasTaggedTemplates : 1;

Ditto.