[webkit-reviews] review granted: [Bug 182712] [Web Animations] Support the copy constructors for KeyframeEffectReadOnly and KeyframeEffect : [Attachment 333636] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 12 17:02:15 PST 2018


Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 182712: [Web Animations] Support the copy constructors for
KeyframeEffectReadOnly and KeyframeEffect
https://bugs.webkit.org/show_bug.cgi?id=182712

Attachment 333636: Patch

https://bugs.webkit.org/attachment.cgi?id=333636&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 333636
  --> https://bugs.webkit.org/attachment.cgi?id=333636
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333636&action=review

> Source/WebCore/animation/KeyframeEffect.cpp:49
> +    UNUSED_PARAM(state);

Just remove the "state" part of the parameter.

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:404
> +    UNUSED_PARAM(state);

Ditto.


More information about the webkit-reviews mailing list