[webkit-reviews] review granted: [Bug 182633] Add a GetIndexMask node and make it an input to GetByVal for array and typed array accesses in DFG SSA : [Attachment 333570] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 12 14:12:46 PST 2018


Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 182633: Add a GetIndexMask node and make it an input to GetByVal for array
and typed array accesses in DFG SSA
https://bugs.webkit.org/show_bug.cgi?id=182633

Attachment 333570: patch

https://bugs.webkit.org/attachment.cgi?id=333570&action=review




--- Comment #20 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 333570
  --> https://bugs.webkit.org/attachment.cgi?id=333570
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333570&action=review

r=me. 

It seems like we could do some amount of optimization in just the DFG if we
always had an index mask. If a basic block had multiple GetByVals then we could
CSE the index masks. It's probably not the most important thing in the world
though.

> Source/JavaScriptCore/dfg/DFGSSALoweringPhase.cpp:101
> +	       default:

Can you add a FIXME: to also do this for arguments objects?


More information about the webkit-reviews mailing list