[webkit-reviews] review granted: [Bug 182660] [Cocoa] Web Automation: provide a way to ask clients the type of a JavaScript dialog : [Attachment 333540] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 10 00:41:12 PST 2018


Carlos Garcia Campos <cgarcia at igalia.com> has granted Brian Burg
<bburg at apple.com>'s request for review:
Bug 182660: [Cocoa] Web Automation: provide a way to ask clients the type of a
JavaScript dialog
https://bugs.webkit.org/show_bug.cgi?id=182660

Attachment 333540: Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=333540&action=review




--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 333540
  --> https://bugs.webkit.org/attachment.cgi?id=333540
Proposed Fix

This looks good to me, r=me because patch is trivial, but maybe an Apple
reviewer should check the new Cocoa API.


More information about the webkit-reviews mailing list