[webkit-reviews] review granted: [Bug 182667] Web Inspector: Canvas tab: tree selection abruptly changes when selecting a recording frame : [Attachment 333548] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <webkit at devinrousso.com> has granted Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 182667: Web Inspector: Canvas tab: tree selection abruptly changes when
selecting a recording frame
https://bugs.webkit.org/show_bug.cgi?id=182667

Attachment 333548: Patch

https://bugs.webkit.org/attachment.cgi?id=333548&action=review




--- Comment #4 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 333548
  --> https://bugs.webkit.org/attachment.cgi?id=333548
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333548&action=review

r=me.  This feels much more smooth.  I still think that we shouldn't
auto-select a recording when viewing a Canvas, but we can discuss that before
doing anything.

> Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css:71
> +.sidebar > .panel.navigation.canvas > .content > .recording-content >
.tree-outline .item.folder-icon > .status {
> +    line-height: 16px;
> +}

This rule already exists below.

> Source/WebInspectorUI/UserInterface/Views/TreeOutline.css:247
> +.tree-outline:not(.large):matches(:focus, .force-focus) .item.selected
.status .indeterminate-progress-spinner {
> +    filter: invert();
> +}

Nice!