[webkit-reviews] review granted: [Bug 182564] REGRESSION (r223440): Copying & pasting a list from Microsoft Word to TinyMCE fails : [Attachment 333520] Skip the test on Windows

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 182564: REGRESSION (r223440): Copying & pasting a list from Microsoft Word
to TinyMCE fails
https://bugs.webkit.org/show_bug.cgi?id=182564

Attachment 333520: Skip the test on Windows

https://bugs.webkit.org/attachment.cgi?id=333520&action=review




--- Comment #19 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 333520
  --> https://bugs.webkit.org/attachment.cgi?id=333520
Skip the test on Windows

View in context: https://bugs.webkit.org/attachment.cgi?id=333520&action=review

> Source/WebCore/editing/MarkupAccumulator.cpp:204
> +    ASSERT(length <= text.data().length());

Perhaps `start + length <= text.data().length()`?

> Source/WebCore/editing/markup.cpp:487
> +	       // Unfortunately, TinyMCE doesn't recognize mso-list inlie style
if the style attribute contains properties.

inlie => inline

> Source/WebCore/editing/markup.cpp:600
> +	   Comment& commentNode = downcast<Comment>(node);

Nit - auto&?