[webkit-reviews] review granted: [Bug 182662] [RenderTreeBuilder] Move RenderBlock::takeChild mutation to a RenderTreeBuilder : [Attachment 333531] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 9 16:16:52 PST 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 182662: [RenderTreeBuilder] Move RenderBlock::takeChild mutation to a
RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=182662

Attachment 333531: Patch

https://bugs.webkit.org/attachment.cgi?id=333531&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 333531
  --> https://bugs.webkit.org/attachment.cgi?id=333531
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333531&action=review

> Source/WebCore/rendering/RenderBlock.cpp:499
> +    return builder.takenChildFromRenderBlock(*this, oldChild);

takeChild

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:473
> +RenderPtr<RenderObject>
RenderTreeBuilder::takenChildFromRenderBlock(RenderBlock& parent, RenderObject&
oldChild)

taken


More information about the webkit-reviews mailing list