[webkit-reviews] review granted: [Bug 182612] [GStreamer][WebAudio] Winamp2-js woes : [Attachment 333476] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 182612: [GStreamer][WebAudio] Winamp2-js woes
https://bugs.webkit.org/show_bug.cgi?id=182612

Attachment 333476: Patch

https://bugs.webkit.org/attachment.cgi?id=333476&action=review




--- Comment #4 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 333476
  --> https://bugs.webkit.org/attachment.cgi?id=333476
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333476&action=review

> LayoutTests/webaudio/silence-after-playback.html:13
> +	    description("Test ensuring silence is outputed after <audio>
playback ended.");

I think outputed does not exist, only output.

> LayoutTests/webaudio/silence-after-playback.html:17
> +	    var context = 0;
> +	    var sampleRate = 44100.0;
> +	    var lengthInSeconds = 3;

I would recommend switching var to const instead of context, that would use let
and leave it uninitialized until it is done in runTest.