[webkit-reviews] review granted: [Bug 182468] [JSC] Update Test262 to Feb 9 version : [Attachment 333394] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 8 14:05:35 PST 2018


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 182468: [JSC] Update Test262 to Feb 9 version
https://bugs.webkit.org/show_bug.cgi?id=182468

Attachment 333394: Patch

https://bugs.webkit.org/attachment.cgi?id=333394&action=review




--- Comment #21 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 333394
  --> https://bugs.webkit.org/attachment.cgi?id=333394
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333394&action=review

r=me

> JSTests/test262.yaml:83859
> -  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], []
> +  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], []
>  - path:
test262/test/language/expressions/tagged-template/cache-differing-expressions-n
ew-function.js
> -  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], [:strict]
> +  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], [:strict]
>  - path:
test262/test/language/expressions/tagged-template/cache-differing-expressions.j
s
> -  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], []
> +  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], []
>  - path:
test262/test/language/expressions/tagged-template/cache-differing-expressions.j
s
> -  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], [:strict]
> +  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], [:strict]

Any idea why we started to fail these?

> JSTests/test262.yaml:83879
> -  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], []
> +  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], []
>  - path:
test262/test/language/expressions/tagged-template/cache-identical-source-eval.j
s
> -  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], [:strict]
> +  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], [:strict]
>  - path:
test262/test/language/expressions/tagged-template/cache-identical-source-new-fu
nction.js
> -  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], []
> +  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], []
>  - path:
test262/test/language/expressions/tagged-template/cache-identical-source-new-fu
nction.js
> -  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], [:strict]
> +  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], [:strict]
>  - path:
test262/test/language/expressions/tagged-template/cache-identical-source.js
> -  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], []
> +  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], []
>  - path:
test262/test/language/expressions/tagged-template/cache-identical-source.js
> -  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], [:strict]
> +  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js",
"../../../../harness/sta.js"], [:strict]

ditto


More information about the webkit-reviews mailing list