[webkit-reviews] review granted: [Bug 182610] [MIPS] JSC needs to be built with -latomic : [Attachment 333412] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 8 12:56:49 PST 2018
Zan Dobersek <zan at falconsigh.net> has granted Guillaume Emont
<guijemont at igalia.com>'s request for review:
Bug 182610: [MIPS] JSC needs to be built with -latomic
https://bugs.webkit.org/show_bug.cgi?id=182610
Attachment 333412: Patch
https://bugs.webkit.org/attachment.cgi?id=333412&action=review
--- Comment #2 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 333412
--> https://bugs.webkit.org/attachment.cgi?id=333412
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=333412&action=review
> Source/JavaScriptCore/CMakeLists.txt:125
> +if (WTF_CPU_MIPS)
> + list(APPEND JavaScriptCore_LIBRARIES
> + -latomic
> + )
> +endif ()
Similar comment to what's in the ChangeLog would be nice here as well.
More information about the webkit-reviews
mailing list