[webkit-reviews] review granted: [Bug 182563] Experiment with alternative implementation of memcpy/memset : [Attachment 333386] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 8 11:21:32 PST 2018


Michael Saboff <msaboff at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 182563: Experiment with alternative implementation of memcpy/memset
https://bugs.webkit.org/show_bug.cgi?id=182563

Attachment 333386: the patch

https://bugs.webkit.org/attachment.cgi?id=333386&action=review




--- Comment #7 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 333386
  --> https://bugs.webkit.org/attachment.cgi?id=333386
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333386&action=review

r=me.  Did you consider implementing only in bmalloc and then a forward
reference in WTF?

> Source/WTF/ChangeLog:36
> +	   reasoning. But that's not quite right, since then we would lose
inlining in the unknonw-size

Spelling *unknonw-size*


More information about the webkit-reviews mailing list