[webkit-reviews] review denied: [Bug 182555] [CMake] Add libsoup platform file : [Attachment 333245] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 7 15:53:25 PST 2018
Michael Catanzaro <mcatanzaro at igalia.com> has denied Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 182555: [CMake] Add libsoup platform file
https://bugs.webkit.org/show_bug.cgi?id=182555
Attachment 333245: Patch
https://bugs.webkit.org/attachment.cgi?id=333245&action=review
--- Comment #16 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 333245
--> https://bugs.webkit.org/attachment.cgi?id=333245
Patch
At this point I think adding a new file is going to make it harder, rather than
easier, to edit the build system. I appreciate the desire to avoid listing
headers multiple times, but it seems like only a small amount of duplication.
More information about the webkit-reviews
mailing list