[webkit-reviews] review granted: [Bug 182559] Restrict Referer to just the origin for third parties in private mode and third parties ITP blocks cookies for in regular mode : [Attachment 333238] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted John Wilander <wilander at apple.com>'s
request for review:
Bug 182559: Restrict Referer to just the origin for third parties in private
mode and third parties ITP blocks cookies for in regular mode
https://bugs.webkit.org/show_bug.cgi?id=182559

Attachment 333238: Patch

https://bugs.webkit.org/attachment.cgi?id=333238&action=review




--- Comment #4 from Andy Estes <aestes at apple.com> ---
Comment on attachment 333238
  --> https://bugs.webkit.org/attachment.cgi?id=333238
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333238&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:146
> +    return request.partitionName(request.url().host()) !=
request.partitionName(request.firstPartyForCookies().host());

It's weird that partitionName() is a member function considering its
implementation doesn't rely on any private information in ResourceRequestBase.
Seems like isThirdPartyRequest() should be a member function of
ResourceRequestBase since it relies entirely on internal state (m_url and
m_firstPartyForCookies). I don't think you need to fix this right now, though.