[webkit-reviews] review denied: [Bug 182551] webkit-patch upload should ask for confirmation before creating a new bug : [Attachment 333216] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied  review:
Bug 182551: webkit-patch upload should ask for confirmation before creating a
new bug
https://bugs.webkit.org/show_bug.cgi?id=182551

Attachment 333216: Patch

https://bugs.webkit.org/attachment.cgi?id=333216&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 333216
  --> https://bugs.webkit.org/attachment.cgi?id=333216
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333216&action=review

> Tools/Scripts/webkitpy/tool/steps/promptforbugortitle.py:44
> +	       if not self._tool.user.confirm("Are you sure you want to create
a new bug?", default="n"):
> +		   self._exit(1)

As indicated by the EWS bot this breaks unit tests, which run
non-interactively. We need to take a similar approach as the CheckStyle [1]
step and re-raise when running non-interactive (i.e.
self._options.non_interactive returns true).

[1]
<https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/steps/checks
tyle.py?rev=228185#L68>