[webkit-reviews] review granted: [Bug 182358] Log error when authentication challenge is blocked due to an insecure request : [Attachment 333184] Patch and layout tests

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 182358: Log error when authentication challenge is blocked due to an
insecure request
https://bugs.webkit.org/show_bug.cgi?id=182358

Attachment 333184: Patch and layout tests

https://bugs.webkit.org/attachment.cgi?id=333184&action=review




--- Comment #4 from Andy Estes <aestes at apple.com> ---
Comment on attachment 333184
  --> https://bugs.webkit.org/attachment.cgi?id=333184
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=333184&action=review

>
LayoutTests/http/tests/security/mixedContent/insecure-download-redirects-to-bas
ic-auth-secure-download.https-expected.txt:2
> +CONSOLE MESSAGE: Blocked
https://localhost:8443/security/mixedContent/resources/subresource/protected-pd
f.php from asking for credentials because navigated from a secure page or went
through an insecure redirect.

The phrasing of this message seems off. Perhaps something like "Blocked <url>
from asking for credentials because it was navigated to from a secure page or
went through an insecure redirect."