[webkit-reviews] review granted: [Bug 182549] put_to_scope/get_from_scope should not cache lexical scopes when expecting a global object : [Attachment 333214] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 182549: put_to_scope/get_from_scope should not cache lexical scopes when
expecting a global object
https://bugs.webkit.org/show_bug.cgi?id=182549

Attachment 333214: Patch

https://bugs.webkit.org/attachment.cgi?id=333214&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 333214
  --> https://bugs.webkit.org/attachment.cgi?id=333214
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333214&action=review

> Source/JavaScriptCore/jit/JITPropertyAccess.cpp:861
> +	       emitLoadWithStructureCheck(scope, structureSlot); // Structure
check covers var injection since we don't cache structures for anything but the
GlobalObject.

Also: this should say that resolve_scope does the check for var injection
firing.