[webkit-reviews] review granted: [Bug 182535] Service workers registrations are saved to disk before the install / activation succeeds : [Attachment 333182] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 6 10:03:39 PST 2018


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 182535: Service workers registrations are saved to disk before the install
/ activation succeeds
https://bugs.webkit.org/show_bug.cgi?id=182535

Attachment 333182: Patch

https://bugs.webkit.org/attachment.cgi?id=333182&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 333182
  --> https://bugs.webkit.org/attachment.cgi?id=333182
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333182&action=review

> Source/WebCore/ChangeLog:10
> +	   This means if the browser exists before the install / activation
succeeds, we may restore

s/exists/exits

> Source/WebCore/ChangeLog:12
> +	   activated.

Indeed, this is in particular important for service worker doing some cache
storage operations only in install step.


More information about the webkit-reviews mailing list