[webkit-reviews] review denied: [Bug 182384] [JHBuild] Add libva in moduleset : [Attachment 332871] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 182384: [JHBuild] Add libva in moduleset
https://bugs.webkit.org/show_bug.cgi?id=182384

Attachment 332871: Patch

https://bugs.webkit.org/attachment.cgi?id=332871&action=review




--- Comment #2 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 332871
  --> https://bugs.webkit.org/attachment.cgi?id=332871
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332871&action=review

> Tools/gstreamer/jhbuild.modules:122
> +   <autotools id="libva" autogenargs="--enable-va-messaging=no">
> +    <branch module="intel/libva/archive/${version}.tar.gz" version="2.0.0"
> +	       checkoutdir="libva-${version}" repo="github-tarball"/>
> +   </autotools>

github on-the-fly tarballs/zips are not guaranteed to have stable hashes and
should be avoided. Example of the issue:
https://github.com/easybuilders/easybuild-easyconfigs/issues/5151

Instead of using this resource, please use the tarball properly released at
https://github.com/intel/libva/releases/download/2.0.0/libva-2.0.0.tar.bz2
which has this sha1sum:
https://github.com/intel/libva/releases/download/2.0.0/libva-2.0.0.tar.bz2.sha1
sum

Notice the diference in the URI  ( /archive/XXX vs /release/XXX )