[webkit-reviews] review granted: [Bug 182488] Use downcast in createLinkPreloadResourceClient : [Attachment 333119] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 6 01:26:38 PST 2018

Antti Koivisto <koivisto at iki.fi> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 182488: Use downcast in createLinkPreloadResourceClient

Attachment 333119: Patch


--- Comment #11 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 333119
  --> https://bugs.webkit.org/attachment.cgi?id=333119

View in context: https://bugs.webkit.org/attachment.cgi?id=333119&action=review

> Source/WebCore/loader/LinkPreloadResourceClients.h:81
> +template<typename SpecificCachedResource>
> +class LinkPreloadCachedResourceClient final: public
LinkPreloadResourceClient, CachedResourceClient {

Template seems like an overkill to cover two cases. How about just having two
create() functions taking CachedScript and CachedTextTrack? The rest of the
type can use CachedResource&.

More information about the webkit-reviews mailing list