[webkit-reviews] review granted: [Bug 182525] [Extra zoom mode] Implement multiple and single select menus : [Attachment 333154] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 5 22:38:37 PST 2018


Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 182525: [Extra zoom mode] Implement multiple and single select menus
https://bugs.webkit.org/show_bug.cgi?id=182525

Attachment 333154: Patch

https://bugs.webkit.org/attachment.cgi?id=333154&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 333154
  --> https://bugs.webkit.org/attachment.cgi?id=333154
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333154&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4353
> +    for (size_t index = 0; index < self.assistedNodeSelectOptions.size();
++index) {

what’s up with this legacy loop?


More information about the webkit-reviews mailing list