[webkit-reviews] review denied: [Bug 182499] Implement stopping of run loop in the WebContent process when using NSRunLoop. : [Attachment 333137] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 182499: Implement stopping of run loop in the WebContent process when using
NSRunLoop.
https://bugs.webkit.org/show_bug.cgi?id=182499

Attachment 333137: Patch

https://bugs.webkit.org/attachment.cgi?id=333137&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 333137
  --> https://bugs.webkit.org/attachment.cgi?id=333137
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333137&action=review

> Source/WebKit/Shared/mac/ChildProcessMac.mm:225
> +    ASSERT(![NSApp isRunning] && [NSRunLoop mainRunLoop]);

NSApp is a global which is initialized when an NSApplication is created, so
(hopefully) it will be nil always, so ![NSApp isRunning] is always true.