[webkit-reviews] review granted: [Bug 182487] Initialize ImageBitmap::m_bitmapData in the constructor. : [Attachment 333082] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 5 11:55:24 PST 2018

Sam Weinig <sam at webkit.org> has granted Ms2ger <Ms2ger at igalia.com>'s request
for review:
Bug 182487: Initialize ImageBitmap::m_bitmapData in the constructor.

Attachment 333082: Patch


--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 333082
  --> https://bugs.webkit.org/attachment.cgi?id=333082

View in context: https://bugs.webkit.org/attachment.cgi?id=333082&action=review

> Source/WebCore/html/ImageBitmap.cpp:-287
> -    // 7. Create a new ImageBitmap object.
> -
> -    auto imageBitmap = create();
> -

I like to leave a note when the steps change order, to indicate to future
readers that the out of order numbers are intentional.

More information about the webkit-reviews mailing list