[webkit-reviews] review granted: [Bug 182461] Web Inspector: Add an experimental setting to enable Sources tab : [Attachment 333042] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 5 11:39:58 PST 2018


Brian Burg <bburg at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 182461: Web Inspector: Add an experimental setting to enable Sources tab
https://bugs.webkit.org/show_bug.cgi?id=182461

Attachment 333042: Patch

https://bugs.webkit.org/attachment.cgi?id=333042&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 333042
  --> https://bugs.webkit.org/attachment.cgi?id=333042
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333042&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:253
> +	   experimentalSettingsView.addSetting(WI.UIString("Sources:"),
WI.settings.experimentalEnableSourcesTab, WI.UIString("Replace Debugger and
Resources tabs with Sources tab"));

Please just call it "Enable Sources Tab".


More information about the webkit-reviews mailing list