[webkit-reviews] review granted: [Bug 181601] Layout Test http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html is flaky : [Attachment 333024] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 5 10:56:15 PST 2018


Alex Christensen <achristensen at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 181601: Layout Test
http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-a
ccess.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=181601

Attachment 333024: Patch

https://bugs.webkit.org/attachment.cgi?id=333024&action=review




--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 333024
  --> https://bugs.webkit.org/attachment.cgi?id=333024
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333024&action=review

> Tools/WebKitTestRunner/TestController.cpp:2674
> +//	 auto* dataStore = WKContextGetWebsiteDataStore(platformContext());

Please don't land this commented-out code.


More information about the webkit-reviews mailing list