[webkit-reviews] review granted: [Bug 182455] Improve NetworkResourceLoader logging so it can be used for 'setCookiesFromDOM' : [Attachment 333093] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 5 10:32:57 PST 2018


Chris Dumez <cdumez at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 182455: Improve NetworkResourceLoader logging so it can be used for
'setCookiesFromDOM'
https://bugs.webkit.org/show_bug.cgi?id=182455

Attachment 333093: Patch

https://bugs.webkit.org/attachment.cgi?id=333093&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 333093
  --> https://bugs.webkit.org/attachment.cgi?id=333093
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333093&action=review

r=me with comment

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:713
> +bool NetworkResourceLoader::shouldLogCookieInformation()

Why did you drop the const? Seems like a method that should be const.


More information about the webkit-reviews mailing list