[webkit-reviews] review granted: [Bug 181166] Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https.html is flaky : [Attachment 333054] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 181166: Layout Test
imported/w3c/web-platform-tests/service-workers/service-worker/register-same-sc
ope-different-script-url.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=181166

Attachment 333054: Patch

https://bugs.webkit.org/attachment.cgi?id=333054&action=review




--- Comment #7 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 333054
  --> https://bugs.webkit.org/attachment.cgi?id=333054
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333054&action=review

> Source/WebCore/workers/service/ServiceWorkerJobData.cpp:39
>      : m_identifier { connectionIdentifier,
generateThreadSafeObjectIdentifier<ServiceWorkerJobIdentifierType>() }

Preexisting issue but seems a bit weird to have m_identifier here and
sourceContext which are both member fields of ServiceWorkerJobData.

> Source/WebCore/workers/service/server/SWServer.cpp:503
> +	   // Abort if the job that scheduled this has not been cancelled.

s/has not/has/

> Source/WebCore/workers/service/server/SWServer.cpp:633
> +	   jobQueue->cancelJobsFromServiceWorker(worker.identifier());

Maybe just me but I would read it more easily with something like
cancelServiceWorkerJobs. Ditto below.