[webkit-reviews] review granted: [Bug 182457] Gigacage: enable only for WebContent process and token executables : [Attachment 333027] patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted JF Bastien
<jfbastien at apple.com>'s request for review:
Bug 182457: Gigacage: enable only for WebContent process and token executables
https://bugs.webkit.org/show_bug.cgi?id=182457

Attachment 333027: patch

https://bugs.webkit.org/attachment.cgi?id=333027&action=review




--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 333027
  --> https://bugs.webkit.org/attachment.cgi?id=333027
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333027&action=review

r=me with comment.

> Source/bmalloc/bmalloc/ProcessCheck.h:34
> +bool gigacageEnabledForProcess() { return false; }

Don't you need to mark this inline or forward declare the function for this to
build?

> Source/bmalloc/bmalloc/ProcessCheck.h:39
> +bool gigacageEnabledForProcess() { return true; }

ditto, idk how this builds...