[webkit-reviews] review requested: [Bug 182474] Multiple bmalloc scavenger threads is unexpected : [Attachment 333062] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 182474: Multiple bmalloc scavenger threads is unexpected
https://bugs.webkit.org/show_bug.cgi?id=182474

Attachment 333062: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=333062&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Created attachment 333062

  --> https://bugs.webkit.org/attachment.cgi?id=333062&action=review

[PATCH] Proposed Fix

I didn't convert all PerProcess<T> => SafePerProcess<T> because it requires
up-front knowledge of the type specializations. This falls over for
IsoTLSDeallocatorEntry, which is constructed with many different
configurations:

    IsoTLSDeallocatorEntry<IsoConfig<32>>
    IsoTLSDeallocatorEntry<IsoConfig<40>>
    IsoTLSDeallocatorEntry<IsoConfig<56>>
    IsoTLSDeallocatorEntry<IsoConfig<72>>
    IsoTLSDeallocatorEntry<IsoConfig<88>>
    IsoTLSDeallocatorEntry<IsoConfig<96>>
    IsoTLSDeallocatorEntry<IsoConfig<104>>
    IsoTLSDeallocatorEntry<IsoConfig<120>>
    ...

This also presents a case where there is another PerProcess<T> cross image
issue. JavaScriptCore and WebCore each produce their own
`IsoTLSDeallocatorEntry<IsoConfig<40>>` instance. So we may have to abandon the
PerProcess<T> templated approach here.