[webkit-reviews] review denied: [Bug 182469] Implement more performant copyLCharsFromUCharSource() for ARM64_32. : [Attachment 333055] proposed patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 4 15:56:10 PST 2018
Mark Lam <mark.lam at apple.com> has denied Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 182469: Implement more performant copyLCharsFromUCharSource() for ARM64_32.
https://bugs.webkit.org/show_bug.cgi?id=182469
Attachment 333055: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=333055&action=review
--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 333055
--> https://bugs.webkit.org/attachment.cgi?id=333055
proposed patch.
After talking with Michael offline, we concluded that this code is probably not
in a hot path anyway. So, staying with the C loop is just fine and less chance
of a bug creeping in. So, I won't land this.
More information about the webkit-reviews
mailing list