[webkit-reviews] review granted: [Bug 182388] Implement createImageBitmap(HTMLVideoElement) : [Attachment 332971] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zan at falconsigh.net> has granted Ms2ger <Ms2ger at igalia.com>'s
request for review:
Bug 182388: Implement createImageBitmap(HTMLVideoElement)
https://bugs.webkit.org/show_bug.cgi?id=182388

Attachment 332971: Patch

https://bugs.webkit.org/attachment.cgi?id=332971&action=review




--- Comment #11 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 332971
  --> https://bugs.webkit.org/attachment.cgi?id=332971
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332971&action=review

> Source/WebCore/html/ImageBitmap.cpp:404
> +    // 5. Let imageBitmap be a new ImageBitmap object.
> +    auto imageBitmap = create();

Following the spec steps, this should sit before the 6.1. step.

> Source/WebCore/html/ImageBitmap.cpp:421
> +    GraphicsContext& c = bitmapData->context();

This can go in the scope below.