[webkit-reviews] review granted: [Bug 182460] UI process sometimes crashes under -[WKContentView _lookupForWebView:] : [Attachment 333039] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 182460: UI process sometimes crashes under -[WKContentView
_lookupForWebView:]
https://bugs.webkit.org/show_bug.cgi?id=182460

Attachment 333039: Patch

https://bugs.webkit.org/attachment.cgi?id=333039&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 333039
  --> https://bugs.webkit.org/attachment.cgi?id=333039
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333039&action=review

r=me

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2008
> +	   auto& editorState = view->_page->editorState();

It seems a bit strange that selectedText exists, but there are no selection
rects. Is it possible we're missing post-layout data in this case? Or perhaps
the if (!selectedText) early return above should be if (selectedText.isEmpty())
instead?