[webkit-reviews] review granted: [Bug 182363] WebAppManifest scope should default to the containing directory of start_url if 'scope' is not specified : [Attachment 332973] Patch v2

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted David Quesada
<david_quesada at apple.com>'s request for review:
Bug 182363: WebAppManifest scope should default to the containing directory of
start_url if 'scope' is not specified
https://bugs.webkit.org/show_bug.cgi?id=182363

Attachment 332973: Patch v2

https://bugs.webkit.org/attachment.cgi?id=332973&action=review




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 332973
  --> https://bugs.webkit.org/attachment.cgi?id=332973
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=332973&action=review

> Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp:198
> -	   return { };
> +	   return { startURL, "./" };

Hm... I would have preferred to have a helper function like you did earlier.