[webkit-reviews] review granted: [Bug 182368] When BytecodeParser inserts Unreachable after ForceOSRExit it needs to update ArgumentPositions for Flushes it inserts : [Attachment 332895] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 182368: When BytecodeParser inserts Unreachable after ForceOSRExit it needs
to update ArgumentPositions for Flushes it inserts
https://bugs.webkit.org/show_bug.cgi?id=182368

Attachment 332895: patch

https://bugs.webkit.org/attachment.cgi?id=332895&action=review




--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 332895
  --> https://bugs.webkit.org/attachment.cgi?id=332895
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332895&action=review

r=me with a suggestion.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6679
> +			   VirtualRegister argument = operand -
(inlineCallFrame ? inlineCallFrame->stackOffset : 0);
> +			   if (argument.isArgument() && !argument.isHeader()) {
> +			       const Vector<ArgumentPosition*>& arguments =
m_inlineCallFrameToArgumentPositions.get(inlineCallFrame);
> +			      
arguments[argument.toArgument()]->addVariable(variable);
> +			   }

If this is only needed when we create a new VAD, maybe you can move this into
the body of the if statement above.