[webkit-reviews] review denied: [Bug 181990] [EME][GStreamer] Add support for the encrypted Caps in GStreamerUtilities : [Attachment 332968] Patch

[bugzilla-daemon at webkit.org]

Charlie Turner <cturner at igalia.com> has denied Yacine Bandou
<bandou.yacine at gmail.com>'s request for review:
Bug 181990: [EME][GStreamer] Add support for the encrypted Caps in
GStreamerUtilities
https://bugs.webkit.org/show_bug.cgi?id=181990

Attachment 332968: Patch

https://bugs.webkit.org/attachment.cgi?id=332968&action=review




--- Comment #7 from Charlie Turner <cturner at igalia.com> ---
Comment on attachment 332968
  --> https://bugs.webkit.org/attachment.cgi?id=332968
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332968&action=review

Forgot to set the r- flag in previous review.

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:184
> +bool areVideoCaps(GstCaps* caps)

The are*Caps functions are all identical apart from the media type prefix
string, could factor these all into one method such has capsIsType(GstCaps,
AsciiLiteral)