[webkit-reviews] review granted: [Bug 182434] [JSC] Clean up ArraySpeciesCreate : [Attachment 332969] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 182434: [JSC] Clean up ArraySpeciesCreate
https://bugs.webkit.org/show_bug.cgi?id=182434

Attachment 332969: Patch

https://bugs.webkit.org/attachment.cgi?id=332969&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 332969
  --> https://bugs.webkit.org/attachment.cgi?id=332969
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332969&action=review

r=me if perf is neutral

> Source/JavaScriptCore/ChangeLog:10
> +	   We have duplicate code in filter, map, concatSlowPath.
> +	   This patch creates a new global private function
@arraySpeciesCreate,
> +	   and use it.

I thought we duplicated the code for perf reasons. Is this a slowdown anywhere?