[webkit-reviews] review granted: [Bug 181800] Web Inspector: Elements tab should have "Jump to Layer" functionality : [Attachment 332940] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 181800: Web Inspector: Elements tab should have "Jump to Layer"
functionality
https://bugs.webkit.org/show_bug.cgi?id=181800

Attachment 332940: Patch

https://bugs.webkit.org/attachment.cgi?id=332940&action=review




--- Comment #11 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 332940
  --> https://bugs.webkit.org/attachment.cgi?id=332940
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332940&action=review

r=me

> Source/WebInspectorUI/ChangeLog:11
> +	   (WI.isShowingElementsTab):

Both of these isShowing*Tab are unused by this patch, but fine to keep.

> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:130
> +	   this.selectLayerById(layer.layerId);

I still think we should do:

    console.assert(layer, "Should always be at least some top level layer");
    if (!layer)
	return;

Maybe this is possible with an element inside of a Shadow DOM?