[webkit-reviews] review granted: [Bug 182036] Create BuildbotBuildEntry in Buildbot syncer in Buildbot 0.9 format : [Attachment 332927] Updated patch with unit-tests

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 182036: Create BuildbotBuildEntry in Buildbot syncer in Buildbot 0.9 format
https://bugs.webkit.org/show_bug.cgi?id=182036

Attachment 332927: Updated patch with unit-tests

https://bugs.webkit.org/attachment.cgi?id=332927&action=review




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 332927
  --> https://bugs.webkit.org/attachment.cgi?id=332927
Updated patch with unit-tests

View in context: https://bugs.webkit.org/attachment.cgi?id=332927&action=review

> Websites/perf.webkit.org/tools/js/buildbot-syncer.js:253
> +    urlForPendingBuild(buildRequestId) { return
this._remote.url(`/#/buildrequests/${buildRequestId}`); }

Huh, it's neat that you can find a build based on a build property.

> Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:1278
> +	       let syncer = BuildbotSyncer._loadConfig(MockRemoteAPI,
sampleiOSConfig(), builderNameToIDMap())[1];
> +	       let buildbotData = samplePendingBuild();
> +	       let pendingEntries = buildbotData.buildrequests.map((entry) =>
new BuildbotBuildEntry(syncer, entry));

Use const.

> Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:1281
> +	       let entry = pendingEntries[0];

Ditto.

> Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:1298
> +	       let syncer = BuildbotSyncer._loadConfig(MockRemoteAPI,
sampleiOSConfig(), builderNameToIDMap())[1];
> +	       let buildbotData = sampleInProgressBuild();
> +	       let entries = buildbotData.builds.map((entry) => new
BuildbotBuildEntry(syncer, entry));
> +
> +	       assert.equal(entries.length, 1);
> +	       let entry = entries[0];

Ditto for using const.

> Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:1315
> +	       let syncer = BuildbotSyncer._loadConfig(MockRemoteAPI,
sampleiOSConfig(), builderNameToIDMap())[1];
> +	       let buildbotData = sampleFinishedBuild();
> +	       let entries = buildbotData.builds.map((entry) => new
BuildbotBuildEntry(syncer, entry));
> +
> +	       assert.deepEqual(entries.length, 1);
> +	       let entry = entries[0];

Ditto.

> Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:1329
> +	       let syncer = BuildbotSyncer._loadConfig(MockRemoteAPI,
sampleiOSConfig(), builderNameToIDMap())[1];
> +	       let buildbotData = {'builds': [sampleInProgressBuildData(),
sampleFinishedBuildData()]};
> +	       let entries = buildbotData.builds.map((entry) => new
BuildbotBuildEntry(syncer, entry));

Ditto.