[webkit-reviews] review requested: [Bug 182036] Create BuildbotBuildEntry in Buildbot syncer in Buildbot 0.9 format : [Attachment 332927] Updated patch with unit-tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 1 18:06:36 PST 2018


Aakash Jain <aakash_jain at apple.com> has asked  for review:
Bug 182036: Create BuildbotBuildEntry in Buildbot syncer in Buildbot 0.9 format
https://bugs.webkit.org/show_bug.cgi?id=182036

Attachment 332927: Updated patch with unit-tests

https://bugs.webkit.org/attachment.cgi?id=332927&action=review




--- Comment #6 from Aakash Jain <aakash_jain at apple.com> ---
Created attachment 332927

  --> https://bugs.webkit.org/attachment.cgi?id=332927&action=review

Updated patch with unit-tests

Added unit-tests.
Removed code-duplication by inheriting BuildbotBuildEntryDeprecated from
BuildbotBuildEntry.
Incorporated review comments.


More information about the webkit-reviews mailing list